Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3782] chore: replace readme not available message #120

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

ben-brooker
Copy link
Contributor

TICKET

ISSUE

Removed "readme not available" message and replaced with package metadata.

Before:
Screenshot 2022-07-05 at 15 11 04
After:
Screenshot 2022-07-05 at 15 11 07

Before:
Screenshot 2022-07-05 at 15 11 11
After:
Screenshot 2022-07-05 at 15 11 14

Replace the readme not available message to improve user experience.

@ben-brooker ben-brooker requested review from ztsorojev and Mim1991 July 5, 2022 14:24
Copy link
Contributor

@ztsorojev ztsorojev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 🏆

Comment on lines 3 to 10
type Props = {
data: {
packageName: string,
version: string,
title: string,
description: string
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can directly expose the fields as props:

Suggested change
type Props = {
data: {
packageName: string,
version: string,
title: string,
description: string
}
}
type Props = {
packageName: string,
version: string,
title: string,
description: string
}

@ben-brooker ben-brooker changed the title chore: replace readme not available message [CT-3782] chore: replace readme not available message Jul 11, 2022
@ben-brooker ben-brooker merged commit ad4f388 into main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants