Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floating solution boxes #221

Closed

Conversation

tobyhodges
Copy link
Member

@tobyhodges tobyhodges commented Aug 10, 2023

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Fixes #220

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

  1. adds an empty div before each floating solution, to prevent the expandable boxes from obscuring other page content.
  2. moves a few code blocks inside these solution boxes, as the infrastructure transition seems to have resulted in some code blocks getting stuck outside the div with the instructions they belong to.

If any relevant discussions have taken place elsewhere, please provide links to these.

See carpentries/lesson-transition#46 (comment) for where this issue with the styling of solution blocks was first reported and discussed.

@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/genomics-r-intro/compare/md-outputs..md-outputs-PR-221

The following changes were observed in the rendered markdown documents:

 md5sum.txt |  2 +-
 setup.md   | 85 ++++++++++++++++++++++++++++++++++++++++++++++++++++----------
 2 files changed, 73 insertions(+), 14 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-08-10 12:41:47 +0000

github-actions bot pushed a commit that referenced this pull request Aug 10, 2023
github-actions bot pushed a commit that referenced this pull request Aug 10, 2023
@tobyhodges
Copy link
Member Author

Closing this in favour of using the spoiler class that will be introduced in the next release of the lesson infrastructure. I will open a new PR when that release has happened.

@tobyhodges tobyhodges closed this Aug 30, 2023
@tobyhodges tobyhodges deleted the fix-floating-solution-boxes branch August 30, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buoyant solution blocks in setup instructions
1 participant