Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use spoiler class divs #300

Merged
merged 1 commit into from
Sep 9, 2023
Merged

use spoiler class divs #300

merged 1 commit into from
Sep 9, 2023

Conversation

tobyhodges
Copy link
Member

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

This switches floating solution divs for the spoiler class introduced in the recent release of the lesson infrastructure

If any relevant discussions have taken place elsewhere, please provide links to these.

See carpentries/sandpaper#502 (comment) for an example of a spoiler class div in action.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-300

The following changes were observed in the rendered markdown documents:

 02-image-basics.md         |  2 +-
 08-connected-components.md |  6 +-----
 md5sum.txt                 |  6 +++---
 setup.md                   | 14 +++-----------
 4 files changed, 8 insertions(+), 20 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-09-06 19:00:58 +0000

github-actions bot pushed a commit that referenced this pull request Sep 6, 2023
Copy link
Contributor

@uschille uschille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this @tobyhodges!

@uschille uschille merged commit e171df5 into main Sep 9, 2023
3 checks passed
@uschille uschille deleted the use-spoiler-divs branch September 9, 2023 02:22
github-actions bot pushed a commit that referenced this pull request Sep 9, 2023
Auto-generated via {sandpaper}
Source  : e171df5
Branch  : main
Author  : Ulf Schiller <[email protected]>
Time    : 2023-09-09 02:22:22 +0000
Message : Merge pull request #300 from datacarpentry/use-spoiler-divs

Use spoiler class divs for solution blocks (adopting lesson template updates)
github-actions bot pushed a commit that referenced this pull request Sep 9, 2023
Auto-generated via {sandpaper}
Source  : 29f7529
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-09-09 02:23:36 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e171df5
Branch  : main
Author  : Ulf Schiller <[email protected]>
Time    : 2023-09-09 02:22:22 +0000
Message : Merge pull request #300 from datacarpentry/use-spoiler-divs

Use spoiler class divs for solution blocks (adopting lesson template updates)
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
Auto-generated via {sandpaper}
Source  : 29f7529
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-09-09 02:23:36 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e171df5
Branch  : main
Author  : Ulf Schiller <[email protected]>
Time    : 2023-09-09 02:22:22 +0000
Message : Merge pull request #300 from datacarpentry/use-spoiler-divs

Use spoiler class divs for solution blocks (adopting lesson template updates)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants