Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDS Schema 3 Deprecation Tasks. #71

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

MDS Schema 3 Deprecation Tasks. #71

wants to merge 3 commits into from

Conversation

svogt0511
Copy link
Contributor

Purpose

In MDS, creating/updating a DOI calls lupo which does the checking and sends back the appropriate error. That mechanism already exists.

The only task that needs to be done is to add appropriate tests.

Spec Documents

closes: #70

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@svogt0511 svogt0511 self-assigned this Oct 26, 2024
Copy link

@codycooperross codycooperross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@jrhoads
Copy link

jrhoads commented Nov 15, 2024

The code changes look good to me.
I think this PR could do with a rebase after #68 and #72.
Then the CI testing should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDS Schema 3 Deprecation Tasks
3 participants