add rake task to rerun waiting claims

app/models/claim.rb

@@ -192,12 +192,13 @@ def to_param # overridden, use uuid instead of id
   def process_data(options = {})
     start
 
-    result = options[:collect_data] || collect_data
+    result = collect_data
 
     if result.body["skip"]
       return finish! if claimed_at.present?
 
       logger.info "[Skipped] #{uid} – #{doi}] #{result.body['reason']}"
+      write_attribute(:error_messages, nil)
 
       skip
     elsif result.body["errors"]
@@ -206,7 +207,7 @@ def process_data(options = {})
       # send notification to Sentry
       # Raven.capture_exception(RuntimeError.new(result.body["errors"].first["title"])) if ENV["SENTRY_DSN"]
 
-      logger.error "[Error] #{uid} – #{doi}] " + result.body["errors"].first["title"].inspect
+      logger.error "[Error] #{uid} – #{doi} " + result.body["errors"].inspect
 
       error!
     elsif result.body["notification"]

app/models/user.rb

@@ -376,7 +376,7 @@ def process_data(options = {})
       # send notification to Sentry
       # Raven.capture_exception(RuntimeError.new(result.body["errors"].first["title"]))if ENV["SENTRY_DSN"]
 
-      logger.error result.body["errors"].first["title"]
+      logger.error result.body["errors"].inspect
     else
       write_attribute(:github_put_code, result.body["put_code"])
     end

lib/tasks/claim.rake

@@ -81,6 +81,14 @@ namespace :claim do
     end
   end
 
+  desc "Push all waiting claims"
+  task waiting: :environment do
+    Claim.waiting.find_each do |claim|
+      ClaimJob.perform_later(claim)
+      puts "[#{claim.aasm_state}] Pushed waiting claim #{claim.doi} for user #{claim.orcid} to ORCID."
+    end
+  end
+
   desc "Get notification_access_token"
   task get_notification_access_token: :environment do
     response = Claim.last.notification.get_notification_access_token(

spec/models/claim_spec.rb

@@ -50,13 +50,20 @@
       expect(response.body).to eq("reason" => "No auto-update permission", "skip" => true)
     end
 
-    it "invalid token" do
+    it "missing token" do
       user = FactoryBot.create(:invalid_user)
       subject = FactoryBot.create(:claim, user: user, orcid: "0000-0003-1419-240x", doi: "10.14454/v6e2-yc93", source_id: "orcid_update")
       response = subject.collect_data
       expect(response.body).to eq("reason" => "No user and/or ORCID token", "skip" => true)
     end
 
+    it "invalid token" do
+      user = FactoryBot.create(:invalid_user, orcid_token: "123")
+      subject = FactoryBot.create(:claim, user: user, orcid: "0000-0003-1419-240x", doi: "10.14454/v6e2-yc93", source_id: "orcid_update")
+      response = subject.collect_data
+      expect(response.body).to eq("errors"=>[{"title"=>"Missing data"}])
+    end
+
     it "no user" do
       subject = FactoryBot.create(:claim, orcid: "0000-0001-6528-2027", doi: "10.14454/v6e2-yc93")
       response = subject.collect_data
@@ -77,14 +84,6 @@
     #   expect(subject.state).to eq("failed")
     # end
 
-    it "no errors with dependency injection" do
-      options = { collect_data: OpenStruct.new(body: { "put_code" => "1069294" }) }
-      expect(subject.process_data(options)).to be true
-      expect(subject.put_code).to eq(put_code)
-      expect(subject.claimed_at).not_to be_blank
-      expect(subject.state).to eq("done")
-    end
-
     it "already exists" do
       FactoryBot.create(:claim, user: user, orcid: "0000-0001-6528-2027", doi: "10.14454/j6gr-cf48", claim_action: "create", claimed_at: Time.zone.now, put_code: put_code)
       expect(subject.process_data).to be true