Import validation updates #1227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vish-cs
commented
Feb 4, 2025
vish-cs
commented
- Invoke dc import tool to generate resolved mcf
- Upload validation output files to GCS
- Validation status check for upload
- Default executor type: CLOUD_RUN
vish-cs
force-pushed
the
executor
branch
2 times, most recently
from
63babc5 to
222cd59
Compare
| output_file = open(self.validation_output, mode='w', encoding='utf-8') | ||
| output_file.write('test,status,message\n') | ||
| status = True | ||
| for config in self.validation_config: | ||
| result = self._run_validation(config) | ||
| output_file.write( | ||
| f'{result.name},{result.status},{result.message}\n') |
There was a problem hiding this comment.
I guess this is a csv row. If yes, comma in result.message might interfere with parsing later. Perhaps consider usign a csv lib. An example code
| config_file) | ||
| import_prefix, 'validation') | ||
| current_data_path = os.path.join(validation_output_path, '*.mcf') | ||
| previous_data_path = latest_version + f'/{import_prefix}/validation/*.mcf' |
There was a problem hiding this comment.
Previous data path might not contain mcfs (for already onbaorded auto-imports). Should we skip if mcfs are missing?
- Invoke dc import tool to generate resolved mcf - Upload validation output files to GCS - Validation status check for upload - Default executor type: CLOUD_RUN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.