SQLite: use projected schema when converting records #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the first returned row contains a
NULL
value, the column type is inferred asNULL
, causing all subsequent rows' values in that column to be converted toNULL
.This PR addresses the issue by using the projected schema when converting records. It also avoids unnecessary conversion during the
try_cast_to
step for primitive types, ensuring they are converted directly to the target types.This resolves incorrect results produced with SQLite acceleration for TPC-DS queries Q51 and Q59.
Note:
Float64
that then will be converted toDecimal
withtry_cast_to
). There will be a follow up PR to improve this as well.