feat: add duckdb checks for unsupported column types #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipleblanc
approved these changes
Nov 7, 2024
phillipleblanc
deleted the
feat/add-duckdb-checks-for-unsupported-column-types
branch
zeroxaa
added a commit
to ReByteAI/datafusion-table-providers
that referenced
this pull request
Nov 22, 2024
…rib#164) * feat: Add DuckDB checks for unsupported column types * deps: Update Cargo.toml * fix: Make serde non-optional, let InvalidTypeAction be Copy * fix: More features shenanigans
zeroxaa
added a commit
to ReByteAI/datafusion-table-providers
that referenced
this pull request
Nov 27, 2024
…rib#164) * feat: Add DuckDB checks for unsupported column types * deps: Update Cargo.toml * fix: Make serde non-optional, let InvalidTypeAction be Copy * fix: More features shenanigans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
get_schema()in DuckDB connections to explicitly check for unsupported column data types.This allows catching unsupported data types from tables before the query executes, which usually results in panics when the DuckDB arrow conversion attempts to convert the data instead of a result that can be handled.
InvalidTypeAction::Errorthrows an error.InvalidTypeAction::Warntraces a warning, and excludes the column from the schema.InvalidTypeAction::Ignoresilently excludes the column from the schema.