Fix MySQLConnection::get_schema for uppercase TableReference
#166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrebnov
reviewed
Nov 12, 2024
| impl MySQLConnection { | ||
| fn column_meta_query_for(tbl: &TableReference) -> String { | ||
| let q = MySqlDialect {} | ||
| .identifier_quote_style("") // parameter unimportant for `MySqlDialect`. |
There was a problem hiding this comment.
- Might be better to move to utility function plus hardcode MySqlDialect quote character w/o using MySqlDialect
- Can identifiers be already quoted?
Sevenannn
reviewed
Nov 12, 2024
phillipleblanc
approved these changes
Nov 13, 2024
zeroxaa
pushed a commit
to ReByteAI/datafusion-table-providers
that referenced
this pull request
Nov 22, 2024
…afusion-contrib#166) * fix MySQLConnection::get_schema for uppercase TableReference * Update mysqlconn.rs * PR reviews * fix clppy * flatten * Update mysqlconn.rs --------- Co-authored-by: Phillip LeBlanc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For MySQL servers with table names (or schema, catalogs),
get_schemadoes not handle uppercases correctly.table_reference.to_quoted_string()uses theDefaultDialectwhich has a differentidentifier_quote_stylethanMySqlDialect.