Fix MySQL errors #180
Merged
Fix MySQL errors #180
+31
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peasee
reviewed
Nov 22, 2024
Co-authored-by: peasee <[email protected]>
Co-authored-by: peasee <[email protected]>
Co-authored-by: peasee <[email protected]>
Co-authored-by: peasee <[email protected]>
peasee
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbconnection::Error::UnableToGetSchema. This error is widely used within theget_schemafunction itself, which really should just bubble up the internal error instead of wrapping duplicatedUnable to get schema:, error messageUnable to get schema:should be set and handled by caller of theget_schemafunction, for example, insql_provider_datafusion::Error.Besides changes for MySQL, this PR also include changes for instructing users to file an issue for DuckDB type related errors.
Before:
After: