Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: copy-dictionary crashing when trying to upsert a source without children #27

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

drscholly
Copy link
Contributor

@drscholly drscholly commented Dec 14, 2023

Checklist

  • I have read the Contribution Guide ;
  • I have read the Contributor License Agreement (CLA) and understand that the submission of this PR will constitute an electronic signature of my agreement of the terms and conditions of DataGalaxy's CLA ;
  • There is an approved issue describing the change when contributing a new feature ;
  • I have added tests that prove my fix is effective or that my feature works ;
  • I have added necessary documentation (if appropriate) ;

Short description of what this resolves:

Instead of raising an Exception, we simply ignore this source and go to the next one.

Changes proposed in this pull request:

  • Add security check before sending API upsert request

@drscholly drscholly requested a review from a team as a code owner December 14, 2023 16:11
Instead of raising an Exception, we simply ignore this source
and go to the next one.
@sailro sailro merged commit 797cacf into datagalaxy-lab:main Feb 13, 2024
4 checks passed
@drscholly drscholly deleted the fix/source_empty branch November 27, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants