Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance copy_links and some code cleaning #60

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

drscholly
Copy link
Contributor

@drscholly drscholly commented Dec 3, 2024

Checklist

  • I have read the Contribution Guide ;
  • I have read the Contributor License Agreement (CLA) and understand that the submission of this PR will constitute an electronic signature of my agreement of the terms and conditions of DataGalaxy's CLA ;
  • There is an approved issue describing the change when contributing a new feature ;
  • I have added tests that prove my fix is effective or that my feature works ;
  • I have added necessary documentation (if appropriate) ;

Short description of what this resolves:

After the recent upgrades, copy_links method is now updated to use the latest developments. As a consequence, some legacy code that is not used anymore is deleted.

Changes proposed in this pull request:

  • Enhance copy_links
  • Delete legacy code

@drscholly drscholly requested a review from a team as a code owner December 3, 2024 16:31
@drscholly drscholly merged commit 932b1b7 into datagalaxy-lab:main Dec 4, 2024
4 checks passed
@drscholly drscholly deleted the core/better_links branch December 4, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant