Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 0.0.1 #47

Open
wants to merge 27 commits into
base: staging
Choose a base branch
from
Open

release: 0.0.1 #47

wants to merge 27 commits into from

Conversation

sheikhshack
Copy link
Collaborator

Context

Why does this PR exist? What problem are you trying to solve? What issue does this close?

Closes [insert issue #]

Approach

How did you solve the problem?

Features:

  • Details ...

Improvements:

  • Details ...

Bug Fixes:

  • Details ...

Before & After Screenshots

BEFORE:
[insert screenshot here]

AFTER:
[insert screenshot here]

Tests

What tests should be run to confirm functionality?

Deploy Notes

Notes regarding deployment of the contained body of work. These should note any
new dependencies, new scripts, etc.

New environment variables:

  • env var : env var details

New scripts:

  • script : script details

New dependencies:

  • dependency : dependency details

New dev dependencies:

  • dependency : dependency details

Risks

Describes potential risks with this PR. Consider carefully what could possibly happen in a worse case scenario. If possible, try to define risks as 2 items: Impact and Likelihood and use your best judgment.

sheikhshack and others added 27 commits January 25, 2022 21:31
feat(backend): implements mailing service
* feat: jpeg to pdf converter

* fix: added path
* feat: add public page Dropbox, Hero

* feat: add form .json, .md

* feat: add s-label to form.json

* feat: finished instructions

* fix: list-style-types for lists

* feat: add form Section

* feat: add conditional fields

* fix: remove error line

* fix: get conditional-number working

* feat: visual completion of form

* chore: clean up package lock

* chore: change from schema, added conditional yesno

* fix: fix yes no to show arbitray file count

Co-authored-by: loongyh <[email protected]>
@gitguardian
Copy link

gitguardian bot commented Jan 28, 2022

⚠️ GitGuardian has uncovered 12 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
Generic High Entropy Secret 3a4c75e backend/src/mailer/templates/standard.ts 15:20 January 26th, 2022 View secret
Generic High Entropy Secret 3a4c75e backend/src/mailer/templates/standard.ts 15:20 January 26th, 2022 View secret
Generic High Entropy Secret 3a4c75e backend/src/mailer/templates/standard.ts 15:20 January 26th, 2022 View secret
Generic High Entropy Secret 76dbf92 backend/src/mailer/templates/standard.ts 01:14 January 28th, 2022 View secret
Generic High Entropy Secret 76dbf92 backend/src/mailer/templates/standard.ts 01:14 January 28th, 2022 View secret
Generic High Entropy Secret 76dbf92 backend/src/mailer/templates/standard.ts 01:14 January 28th, 2022 View secret
Generic High Entropy Secret 3a4c75e backend/src/mailer/templates/standard.ts 15:20 January 26th, 2022 View secret
Generic High Entropy Secret 3a4c75e backend/src/mailer/templates/standard.ts 15:20 January 26th, 2022 View secret
Generic High Entropy Secret 3a4c75e backend/src/mailer/templates/standard.ts 15:20 January 26th, 2022 View secret
Generic High Entropy Secret 76dbf92 backend/src/mailer/templates/standard.ts 01:14 January 28th, 2022 View secret
Generic High Entropy Secret 76dbf92 backend/src/mailer/templates/standard.ts 01:14 January 28th, 2022 View secret
Generic High Entropy Secret 76dbf92 backend/src/mailer/templates/standard.ts 01:14 January 28th, 2022 View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.

 

Our GitHub checks need improvements? Share your feedbacks

Comment on lines +57 to +59
.findByIdAndUpdate(id, {
status,
})

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources

This query depends on [a user-provided value](1).
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql.yml:analyze/language:javascript. As part of the setup process, we have scanned this repository and found 5 existing alerts. Please check the repository Security tab to see all alerts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants