Skip to content

Commit

Permalink
Integrate review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
manojvazirani committed Aug 20, 2020
1 parent 801fd70 commit d0d7c61
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Terraform/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ az ad sp create-for-rbac --name "myApp" --role contributor \

Add the JSON output as secrets TF_VAR_agent_client_id, TF_VAR_agent_client_secret, TF_VAR_subscription_id, TF_VAR_tenant_id in the GitHub repository. For steps to create and storing secrets, please check [here](https://docs.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets)

Store the Terraform templates in a directory and update the value of `TF_WORKING_DIR` in the environment for deployment.
The terraform deployment actions expects the terraform templates to be stored in the root directory. If the terraform templates are stored in a different directory, update the path to terraform actions. More information on terraform actions can be found [here](https://www.terraform.io/docs/github-actions/setup-terraform.html)

For additional help on how use Azure actions, please refer [here](https://github.com/Azure/Actions)

Expand Down
3 changes: 3 additions & 0 deletions Terraform/terraform-deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
branches:
- master

# Update secrets TF_VAR_agent_client_id, TF_VAR_agent_client_secret, TF_VAR_subscription_id, TF_VAR_tenant_id in the GitHub repository.
# For steps to create and store secrets, please check https://docs.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets

jobs:
terraform:
name: "Terraform"
Expand Down

0 comments on commit d0d7c61

Please sign in to comment.