-
Notifications
You must be signed in to change notification settings - Fork 84
convert github.com raw url to raw.githack.com url / adding etherpad on the right #163
Conversation
This update converts github raw url (that doesn't set content-type) to raw.githack.com url so that user can open the pdf directly on the browser
could not test locally, even if I allow cookies for 127.0.0.1 chromium doesn't really record it and I come back to
even going to localhost doesn't help... will deploy/test tomorrow. If PDF was a separate PR - would have been easier to review/merge |
and going back to df7edb2 before presumably etherpad addition - doesn't work |
Does it work on my fork? https://soichi.us/ohbm2020-posters/#/room/3/ohbm2020-3 |
Nope (although this time coming from phone not laptop) - similar cookie issue |
I just tested with a few people and they all seemed to work.. on my fork. I
am wondering if the issue is caused by your browser / OS?
[image: image.png]
I did forget to hide the note for mobile.. so I will do that now.
…On Thu, Jul 2, 2020 at 8:51 AM Yaroslav Halchenko ***@***.***> wrote:
Nope (although this time coming from phone not laptop) - similar cookie
issue
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#163 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHBR6ENDYVJBG6LVGTS5ODRZR7E5ANCNFSM4OODUIFA>
.
|
from your clone:
I wonder if there could be at least a message (e.g. instead of error msg) in such cases instructing user to do that (add etherpad.wikimedia.org or allow for third-party cookies). I am not sure why chromium doesn't ask me explicitly for cookies from that website to be allowed or not. |
Actually.. I was able to recreate this problem on some posters (happens on 1966 consistently). It looks like etherpad is trying to send some warning message through "top" property.
I don't know 1) what |
submit issue to etherpad and see what they say? |
I've looked and it looks like they've already fixed it. Also, I just refreshed 1966 and now it's working again.. :( I am guessing wikimedia.org has some old code stuck in one of their servers, or CDN.. or something) |
FWIW, twitted:
|
ref #143
This update converts github raw url (that doesn't set content-type) to raw.githack.com url so that user can open the pdf directly on the browser.