Skip to content
This repository has been archived by the owner on Jun 26, 2022. It is now read-only.

convert github.com raw url to raw.githack.com url / adding etherpad on the right #163

Merged
merged 7 commits into from
Jul 2, 2020

Conversation

soichih
Copy link
Contributor

@soichih soichih commented Jul 1, 2020

ref #143

This update converts github raw url (that doesn't set content-type) to raw.githack.com url so that user can open the pdf directly on the browser.

This update converts github raw url (that doesn't set content-type) to
raw.githack.com url so that user can open the pdf directly on the
browser
@soichih soichih changed the title convert github.com raw url to raw.githack.com url convert github.com raw url to raw.githack.com url / adding etherpad on the right Jul 2, 2020
@soichih
Copy link
Contributor Author

soichih commented Jul 2, 2020

image

The etherpad tries to address these issues
REF #127
#157 (somewhat)

@yarikoptic
Copy link
Contributor

could not test locally, even if I allow cookies for 127.0.0.1 chromium doesn't really record it and I come back to

An error occurred
Please press and hold Ctrl and press F5 to reload this page
If the problem persists please send this error message to your webmaster:

ErrorId: trC36oQ4gYH2Mk17yHq0
URL: https://etherpad.wikimedia.org/p/ohbm2020-3
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.116 Safari/537.36
Uncaught TypeError: Cannot read property 'setStateIdle' of null in https://etherpad.wikimedia.org/javascripts/lib/ep_etherpad-lite/static/js/pad.js?callback=require.define&v=2eb54623 at line 3

even going to localhost doesn't help... will deploy/test tomorrow. If PDF was a separate PR - would have been easier to review/merge

@yarikoptic
Copy link
Contributor

and going back to df7edb2 before presumably etherpad addition - doesn't work

@soichih
Copy link
Contributor Author

soichih commented Jul 2, 2020

Does it work on my fork? https://soichi.us/ohbm2020-posters/#/room/3/ohbm2020-3

@yarikoptic
Copy link
Contributor

Nope (although this time coming from phone not laptop) - similar cookie issue

@soichih
Copy link
Contributor Author

soichih commented Jul 2, 2020 via email

@yarikoptic
Copy link
Contributor

from your clone:

  • worked in firefox
  • in chromium (and I guess chome on android as I reported earlier), it works ONLY if either I
    • disable "Block third-party cookies". adding your website (soichi.us) to the list of allowed doesn't help
    • manually add etherpad.wikimedia.org to the list of allowed websites for the cookies

I wonder if there could be at least a message (e.g. instead of error msg) in such cases instructing user to do that (add etherpad.wikimedia.org or allow for third-party cookies). I am not sure why chromium doesn't ask me explicitly for cookies from that website to be allowed or not.

@yarikoptic yarikoptic merged commit e3545db into datalad-datasets:gh-pages Jul 2, 2020
This was referenced Jul 2, 2020
@soichih
Copy link
Contributor Author

soichih commented Jul 2, 2020

Actually.. I was able to recreate this problem on some posters (happens on 1966 consistently).

It looks like etherpad is trying to send some warning message through "top" property.

                r[t] = i(function() {
                    "setAuthorInfo" !== t || arguments[0] ? d[n + t].apply(this, arguments) : top.console.warn("setAuthorInfo AuthorId not set for some reason", arguments)
                })

I don't know 1) what AuthorId is, why it's not set and how to set it. 2) why this only happens on 1966, 3) if this is a bug with etherpad itself.. I don't think it should be accessing window.top to post messages like that.

@yarikoptic
Copy link
Contributor

submit issue to etherpad and see what they say?

@soichih
Copy link
Contributor Author

soichih commented Jul 2, 2020

I've looked and it looks like they've already fixed it.

https://github.com/ether/etherpad-lite/blob/c5584fb5b41a67704bcad4178a5420377b6988ab/src/static/js/ace2_inner.js#L344

Also, I just refreshed 1966 and now it's working again.. :( I am guessing wikimedia.org has some old code stuck in one of their servers, or CDN.. or something)

@yarikoptic
Copy link
Contributor

FWIW, twitted:

An exciting new feature to the #GallOP (our platform name now) got just added by the amazing @soichih -- integration with @EtherpadOrg! "Video chat" has "Notes" on the right. Some rough corners might be yet to polish - please provide feedback! #OHBM2020Posters FOREVER! pic.twitter.com/1iLAENlcLk

— Yaroslav Halchenko (@yarikoptic) July 2, 2020

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants