Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand GitHub Actions workflow to build and run Kotlin samples in CI #3

Conversation

datalogics-saharay
Copy link
Contributor

@datalogics-saharay datalogics-saharay commented Jan 17, 2024

Let's expand GitHub Actions CI workflow to build and run Kotlin samples.

@datalogics-saharay datalogics-saharay force-pushed the implement-CI-for-kotlin-samples branch from e7afe6f to 835835b Compare January 17, 2024 22:43
- Let's assemble a JAR file of the sample with the Maven "package"
  command, so that is easily run in CI. In order to build a JAR
  with the dependencies, we had to utilize the maven-assembly-plugin
  in the pom.xml and set the mainClass property in the configuration
  section of the plugin.
@datalogics-saharay datalogics-saharay changed the title Expand CI workflow to build and run Kotlin samples Expand GitHub Actions workflow to build and run Kotlin samples in CI Jan 19, 2024
- The GitHub Actions runner uses Powershell as the default shell on
  Windows. For some reason, that causes the java.library.path argument
  to not get processed correctly and then the samples fail to run. Let's
  try to set the default shell to bash to see if we can get around this.
@datalogics-saharay datalogics-saharay force-pushed the implement-CI-for-kotlin-samples branch from ae513e4 to dba8360 Compare January 26, 2024 22:24
- The samples were failing to run on Windows because it was unable to
  find the dependent libraries for the main APDFL 18 DLL, even though
  the java.library.path argument was being set in the run command. It
  turns out there's a JDK bug where the java.library.path was not being
  honored on Windows systems:
  https://bugs.openjdk.org/browse/JDK-8213772?focusedCommentId=14222348&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14222348.

- As a workaround, let's add the path to the dependency DLLs to the system PATH
  and assign the java.library.path variable to the system PATH to see if that helps
  the samples run on Windows.
@datalogics-saharay datalogics-saharay force-pushed the implement-CI-for-kotlin-samples branch from b8855ab to db554f6 Compare January 26, 2024 23:10
@datalogics-saharay datalogics-saharay force-pushed the implement-CI-for-kotlin-samples branch from 3fad836 to 29a3017 Compare January 29, 2024 17:21
@datalogics-saharay datalogics-saharay force-pushed the implement-CI-for-kotlin-samples branch from 4d1c6a8 to 75ba670 Compare January 29, 2024 20:41
@datalogics-saharay datalogics-saharay force-pushed the implement-CI-for-kotlin-samples branch from d6b8caa to aff5e38 Compare January 31, 2024 17:43
@datalogics-saharay datalogics-saharay marked this pull request as ready for review January 31, 2024 17:47
@datalogics-robl datalogics-robl merged commit 2e02558 into datalogics:develop Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants