-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand GitHub Actions workflow to build and run Kotlin samples in CI #3
Merged
datalogics-robl
merged 22 commits into
datalogics:develop
from
datalogics-saharay:implement-CI-for-kotlin-samples
Feb 1, 2024
Merged
Expand GitHub Actions workflow to build and run Kotlin samples in CI #3
datalogics-robl
merged 22 commits into
datalogics:develop
from
datalogics-saharay:implement-CI-for-kotlin-samples
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datalogics-saharay
force-pushed
the
implement-CI-for-kotlin-samples
branch
from
January 17, 2024 22:43
e7afe6f
to
835835b
Compare
- Let's assemble a JAR file of the sample with the Maven "package" command, so that is easily run in CI. In order to build a JAR with the dependencies, we had to utilize the maven-assembly-plugin in the pom.xml and set the mainClass property in the configuration section of the plugin.
datalogics-saharay
changed the title
Expand CI workflow to build and run Kotlin samples
Expand GitHub Actions workflow to build and run Kotlin samples in CI
Jan 19, 2024
- The GitHub Actions runner uses Powershell as the default shell on Windows. For some reason, that causes the java.library.path argument to not get processed correctly and then the samples fail to run. Let's try to set the default shell to bash to see if we can get around this.
datalogics-saharay
force-pushed
the
implement-CI-for-kotlin-samples
branch
from
January 26, 2024 22:24
ae513e4
to
dba8360
Compare
- The samples were failing to run on Windows because it was unable to find the dependent libraries for the main APDFL 18 DLL, even though the java.library.path argument was being set in the run command. It turns out there's a JDK bug where the java.library.path was not being honored on Windows systems: https://bugs.openjdk.org/browse/JDK-8213772?focusedCommentId=14222348&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14222348. - As a workaround, let's add the path to the dependency DLLs to the system PATH and assign the java.library.path variable to the system PATH to see if that helps the samples run on Windows.
datalogics-saharay
force-pushed
the
implement-CI-for-kotlin-samples
branch
from
January 26, 2024 23:10
b8855ab
to
db554f6
Compare
datalogics-saharay
force-pushed
the
implement-CI-for-kotlin-samples
branch
from
January 29, 2024 17:21
3fad836
to
29a3017
Compare
- Apparently, the currently running action can't access the updated path, so let's try setting the path in a different step to see if the "Run samples" step will pick up on the changed PATH.
datalogics-saharay
force-pushed
the
implement-CI-for-kotlin-samples
branch
from
January 29, 2024 20:41
4d1c6a8
to
75ba670
Compare
datalogics-saharay
force-pushed
the
implement-CI-for-kotlin-samples
branch
from
January 31, 2024 17:43
d6b8caa
to
aff5e38
Compare
datalogics-robl
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's expand GitHub Actions CI workflow to build and run Kotlin samples.