fix bill_text template #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgregg
commented
Jan 13, 2024
| @@ -96,15 +96,6 @@ def clean_html(text): | |||
| return re.sub(r"&(?:\w+|#\d+);", "", value) | |||
|
|
|||
|
|
|||
| @register.filter | |||
There was a problem hiding this comment.
this filter was only used in bill_text.txt and we aren't using it anymore.
fgregg
commented
Jan 13, 2024
| @@ -60,9 +57,6 @@ def prepare(self, obj): | |||
|
|
|||
| return data | |||
|
|
|||
| def prepare_topics(self, obj): | |||
There was a problem hiding this comment.
can get it more directly with model_attr
fgregg
commented
Jan 13, 2024
| source_url = indexes.CharField(model_attr="sources__url", indexed=False) | ||
| source_note = indexes.CharField(model_attr="sources__note") | ||
| abstract = indexes.CharField( |
There was a problem hiding this comment.
this is always empty for chicago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had some out of date references which was causing the full text search to miss bills like in #388.
closes #388
I also added a management command to preview the content that will be search to the search enginge.
Before the changes this is what would have been sent:
{ 'abstract': '', 'actions': [ 'R2023-0004166 action on 2023-09-14', 'R2023-0004166 action on 2023-09-14', 'R2023-0004166 action on 2023-11-01', 'R2023-0004166 action on 2023-11-01', 'R2023-0004166 action on 2023-11-07'], 'bill_type': 'resolution', 'bill_type_exact': None, 'boost': 1.095890410958904, 'controlling_body': ['Chicago City Council'], 'controlling_body_exact': None, 'description': 'Submission of public question by referendum to Chicago ' 'voters for increase in Chicago real estate transfer tax ' 'rates', 'django_ct': 'chicago.chicagobill', 'django_id': 'ocd-bill/722e9d40-9499-4a49-bb5d-8dd123866555', 'friendly_name': 'Resolution R2023-0004166', 'full_text': 'None', 'id': 'ocd-bill/722e9d40-9499-4a49-bb5d-8dd123866555', 'identifier': 'R2023-0004166', 'inferred_status': 'Approved', 'inferred_status_exact': None, 'last_action_date': datetime.date(2023, 11, 7), 'legislative_session': '2023', 'legislative_session_exact': None, 'ocr_full_text': 'None', 'slug': 'r2023-0004166', 'sort_name': 'ResolutionR2023-0004166', 'sort_name_exact': None, 'source_note': "['elms_api', 'web']", 'source_url': "['https://api.chicityclerkelms.chicago.gov/matter/4C434D15-6452-EE11-BE6E-001DD8097692', " "'https://chicityclerkelms.chicago.gov/Matter/?matterId=4C434D15-6452-EE11-BE6E-001DD8097692']", 'sponsorships': ['Johnson, Brandon'], 'sponsorships_exact': None, 'text': '\n' 'R2023-0004166\n' 'Resolution R2023-0004166\n' '['resolution']\n' '\n' '\n' '\n' ' \n' ' Johnson, Brandon\n' ' \n' '\n' '\n' ' Chicago City Council\n' ' Introduced\n' '\n' ' Chicago City Council\n' ' Referred\n' '\n' ' Committee on Committees and Rules\n' ' Recommended to Pass\n' '\n' ' Chicago City Council\n' ' Deferred and Published\n' '\n' ' Chicago City Council\n' ' Passed\n' '\n' '\n' '\tNon-Routine\n' '\n' '\tCity Matters\n' '\n' '\tElections\n' '\n' 'None\n', 'topics': ['Non-Routine', 'City Matters', 'Elections'], 'topics_exact': None}and with the fixes, this what will be sent now:
{ 'actions': [ 'R2023-0004166 action on 2023-09-14', 'R2023-0004166 action on 2023-09-14', 'R2023-0004166 action on 2023-11-01', 'R2023-0004166 action on 2023-11-01', 'R2023-0004166 action on 2023-11-07'], 'bill_type': 'resolution', 'bill_type_exact': None, 'boost': 1.095890410958904, 'controlling_body': ['Chicago City Council'], 'controlling_body_exact': None, 'django_ct': 'chicago.chicagobill', 'django_id': 'ocd-bill/722e9d40-9499-4a49-bb5d-8dd123866555', 'friendly_name': 'Resolution R2023-0004166', 'full_text': 'None', 'id': 'ocd-bill/722e9d40-9499-4a49-bb5d-8dd123866555', 'identifier': 'R2023-0004166', 'inferred_status': 'Approved', 'inferred_status_exact': None, 'last_action_date': datetime.date(2023, 11, 7), 'legislative_session': '2023', 'legislative_session_exact': None, 'ocr_full_text': 'None', 'slug': 'r2023-0004166', 'sort_name': 'ResolutionR2023-0004166', 'sort_name_exact': None, 'source_note': "['elms_api', 'web']", 'source_url': "['https://api.chicityclerkelms.chicago.gov/matter/4C434D15-6452-EE11-BE6E-001DD8097692', " "'https://chicityclerkelms.chicago.gov/Matter/?matterId=4C434D15-6452-EE11-BE6E-001DD8097692']", 'sponsorships': ['Johnson, Brandon'], 'sponsorships_exact': None, 'text': '\n' 'Resolution R2023-0004166\n' '\n' ' R2023-0004166\n' '\n' '\n' 'resolution\n' '\n' 'Submission of public question by referendum to Chicago voters for ' 'increase in Chicago real estate transfer tax rates\n' '\n' ' \n' ' Johnson, Brandon\n' ' \n' '\n' '\n' ' Chicago City Council\n' ' Introduced\n' '\n' ' Chicago City Council\n' ' Referred\n' '\n' ' Committee on Committees and Rules\n' ' Recommended to Pass\n' '\n' ' Chicago City Council\n' ' Deferred and Published\n' '\n' ' Chicago City Council\n' ' Passed\n' '\n' '\n' '\tNon-Routine\n' '\n' '\tCity Matters\n' '\n' '\tElections\n' '\n' 'None\n', 'title': 'Submission of public question by referendum to Chicago voters ' 'for increase in Chicago real estate transfer tax rates', 'topics': ['Non-Routine', 'City Matters', 'Elections'], 'topics_exact': None}