This repository has been archived by the owner on Apr 17, 2018. It is now read-only.
Fixed Persisted Updating through #{singular}_list= (currently does not update frozen_{singular}_list) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g_list (tags-only example; works for user defined context)
morygonzalez
added a commit
to morygonzalez/dm-tags
that referenced
this pull request
Jun 4, 2016
…rently does not update frozen_{singular}_list) datamapper#6"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that updating with 'tag_list=' does not reflect changes onto @frozen_tag_list, and therefore the updated list never gets properly persisted in the database (which has a frozen_tag_list field).
model.tag_list = 'test, me out, please '
model.tag_list #=> ['me out', 'please', 'test'] # Sanitized and alphabetized
model.save #=> true
model.tag_list = 'test, again'
model.save #=> true
But if we pull it back from storage, the update is lost.
model = MyModel.get(model.id)
model.tag_list #=> ['me out', 'please', 'test'] # NOT UPDATED TO ['test', 'again']
Simply called 'update_#{collection}' at the end of '#{singular}_list=' to handle this.
This was a problem I had with 1.0.2 and older, so it may be resolved now.