fix #15 #25
fix #15 #25
Conversation
frblo
requested review from
foodelevator
and removed request for
foodelevator
|
|
||
| member, err := database.GetMember(db, memberID) | ||
| if err != nil { | ||
| c.Redirect(http.StatusNotFound, "") |
There was a problem hiding this comment.
Shouldn't be a redirect if it's not a 3XX code (pretty sure gin will complain about this, but it's also against the web spec or whatever that thing is called)
Should probably be something c.Error or c.SetStatusCode or whatever (I have no idea what methods exist)
| if len(authors) == 1 { | ||
| return sb.String() | ||
| return template.HTML(sb.String()) |
There was a problem hiding this comment.
You're only supposed to cast a string to a template.HTML if that is supposed to be interpreted as html, right? Are the author's names supposed to be interpreted as such?
| } | ||
|
|
||
| func authorURL(name string, kthID string) template.HTML { | ||
| url := fmt.Sprintf(`<a href="/redaqtionen/%v">%v</a>`, kthID, name) |
There was a problem hiding this comment.
Same here as above. You should probably move some logic into the template rather than Sprintfing html here. Or this function could call a very small template.
| @@ -485,7 +486,7 @@ func TestAuthortext(t *testing.T) { | |||
| // Test case 1: Valid AuthorText | |||
| authorText := sql.NullString{String: "Skriven av Test Testström", Valid: true} | |||
| authors := []database.Author{{PreferedName: sql.NullString{String: "Ej Korrektström", Valid: true}, KthID: "testsupp"}} | |||
| expected := "Skriven av Test Testström" | |||
| expected := template.HTML("Skriven av Test Testström") | |||
There was a problem hiding this comment.
Is this what happens if you take soffan? (referring to the test, not this diff specifically)
Adds a page for displaying information about individual members of redaqtionen, along with all articles which they've been credited.