Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add extern role if user has a year role when verifying #173

Merged
merged 10 commits into from
Sep 22, 2024
Merged

Don't add extern role if user has a year role when verifying #173

merged 10 commits into from
Sep 22, 2024

Conversation

Benjaneb
Copy link
Collaborator

Fixes #171

@Benjaneb
Copy link
Collaborator Author

Before merge: move removal of "old verified" outside of if (year && yearRole) and modify that if+else-statement accordingly.

@Benjaneb Benjaneb merged commit 5edaa88 into main Sep 22, 2024
2 checks passed
@Benjaneb Benjaneb deleted the dont-add-extern branch September 22, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crystopherross crystopherross crystopherross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not add role "Extern" if someone already has a class role when verifying
2 participants
@Benjaneb @crystopherross