[update][s] Fixing Dial code problem - refs #87. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuveyatsu
reviewed
Oct 8, 2024
| import pandas as pd | ||
|
|
||
| def format_dial_codes(dial): |
There was a problem hiding this comment.
@gradedSystem what was the old script that handled this case correctly?
There was a problem hiding this comment.
@anuveyatsu I believe the old script scripts/statoids.py should be handling this case:
country-codes/scripts/statoids.py
Lines 82 to 87 in 92bbe1a
however it doesn't seem to work in this case
There was a problem hiding this comment.
@gradedSystem ok so this is a unique case only for Dominican Republic. In this case I'm OK with the change you are proposing in this PR 👍
There was a problem hiding this comment.
Yes it is the only case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
Reference to the issue:
#87
cc @anuveyatsu