Handle units in some YAML settings (post CASSANDRA-15234) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,7 +31,9 @@ data class CassandraYaml(val data : JsonNode) : YamlConfig(data) { | |||
| val partitioner get() = get("partitioner") | |||
| val memtableAllocationType get() = get("memtable_allocation_type") | |||
| val authorizer get() = get("authorizer") | |||
| private val rowCacheSizeInMB get() = (get("row_cache_size","0")).toInt() | |||
| val rowCacheSizeInMB get() = ( | |||
| get("row_cache_size", "0").replace("MiB", "") | |||
There was a problem hiding this comment.
could be GiB (or KiB), or GB, MB, KB
There was a problem hiding this comment.
Could I then delete all non-numeric characters ? Something like .replace("\D+", "") ?
There was a problem hiding this comment.
yeah, i agree to that
(since we're only looking for non-zero here)
There was a problem hiding this comment.
Pushed a commit doing this.
michaelsembwever
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that at least due to CASSANDRA-15234 the
cassandra.yamlfile started to feature units (egMiB) for some settings.Montecristo is mostly not troubled by this, except for the
row_cache_sizewhere we actually parse the value to see if it's bigger than 0.This PR improves that parsing by removing the
MiBstring. I could not find a decent(-ly simple) de-humanization library to drop in, so I went for a quick fix like this.I'm also having issues with the unit tests. I think the
Assertionslibrary is not taken into the accunt. I'm commiting a failing unit test, hoping to see the CI here to fail.