Artifacts.loadViaParser(..) should also (automatically) accept files with '.txt' suffixes #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsembwever
force-pushed
the
mck/fix-ps-aux-loading
branch
from
d2e6b98 to
bfceba3
Compare
…with '.txt' suffixes And parsing of ps-aux file should be sensitive to the non-daemon cassandra/dse processes that can be running. Fallback parsing of jvm flags from jvm.options now respects all jvm(.*-server)?.options files.
michaelsembwever
force-pushed
the
mck/fix-ps-aux-loading
branch
from
bfceba3 to
2245be1
Compare
rzvoncek
approved these changes
Sep 3, 2024
|
I know, I agree. I will come back to adding units. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And parsing of ps-aux file should be sensitive to the non-daemon cassandra/dse processes that can be running.