CNDB-12406: Make CachedReplicaRows thresholds flexible to be set via …

[driftx]

What is the issue

cached_replica_rows_[warn,fail]_threshold can only be set at in the yaml or via JMX.

What does this PR fix and why was it fixed

Adds system properties for these.

[github-actions]

Checklist before you submit for review

• Make sure there is a PR in the CNDB project updating the Converged Cassandra version
• Use NoSpamLogger for log lines that may appear frequently in the logs
• Verify test results on Butler
• Test coverage for new/modified code is > 80%
• Proper code formatting
• Proper title for each commit staring with the project-issue number, like CNDB-1234
• Each commit has a meaningful description
• Each commit is not very long and contains related changes
• Renames, moves and reformatting are in distinct commits

[sonarqubecloud]

Quality Gate failed

Failed conditions
60.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[cassci-bot]

✔️ Build ds-cassandra-pr-gate/PR-1551 approved by Butler

---

Approved by Butler
See build details here

[djatnieks]

Please consider the suggestion that will make it easier to port to main-5.0.

[djatnieks]

I think this could be something like:

this.cachedRowsWarnThreshold = CACHED_REPLICA_ROWS_WARN_THRESHOLD.getInt(cachedRowsWarnThreshold);
this.cachedRowsFailThreshold = CACHED_REPLICA_ROWS_FAIL_THRESHOLD.getInt(cachedRowsFailThreshold);

This will make it easier to port to main-5.0 where checkstyle will complain about using System.getProperty... :)