Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: HCD-74: Fix CorruptSSTableException in UCS with compression #1602

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

szymon-miezal
Copy link

@szymon-miezal szymon-miezal commented Feb 24, 2025

Adjust the partition position by 1 when reading the compression metadata.

Adjusted the last position by 1 to make it not exceed the compression medata.
Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

}

@Test
public void testDoNotFailOnChunkEndingPosition()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not proud of this test, in fact the opposite but I haven't found a neat readable way to test it in a more e2e fashion.

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1602 rejected by Butler


1 new test failure(s) in 3 builds
See build details here


Found 1 new test failures

Test Explanation Branch history Upstream history
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴🔴🔴 🔵🔵🔵🔵🔵🔵🔵

Found 2 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants