CNDB-12683 make name validation functions clear #1605
+83
−63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
The names of functions validating schema object names are missing semantics and placed in different files. This led to incorrect use of them and to https://github.com/riptano/cndb/issues/12451, https://github.com/riptano/cndb/issues/12683, https://github.com/riptano/cndb/issues/13007, https://github.com/riptano/cndb/issues/13043.
What does this PR fix and why was it fixed
This PR improves names of the name validation functions with their actual semantics. It also co-locates them in a single files. The error messages are fixed accordently.
This PR also makes minor change to a long table name test to use the keyspace name reported in an incident.