Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDB-12683 make name validation functions clear #1605

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

k-rus
Copy link

@k-rus k-rus commented Feb 25, 2025

What is the issue

The names of functions validating schema object names are missing semantics and placed in different files. This led to incorrect use of them and to https://github.com/riptano/cndb/issues/12451, https://github.com/riptano/cndb/issues/12683, https://github.com/riptano/cndb/issues/13007, https://github.com/riptano/cndb/issues/13043.

What does this PR fix and why was it fixed

This PR improves names of the name validation functions with their actual semantics. It also co-locates them in a single files. The error messages are fixed accordently.

This PR also makes minor change to a long table name test to use the keyspace name reported in an incident.

Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1605 rejected by Butler


4 new test failure(s) in 1 builds
See build details here


Found 4 new test failures

Test Explanation Branch history Upstream history
...tiveControllerTest.testLongTableNameFromOptions regression 🔴 🔵🔵🔵🔵
...tionControllerConfigTest.testStoreLongTableName regression 🔴 🔵
...bleValidationTest.testCreatingTableWithLongName regression 🔴 🔵🔵🔵🔵
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴 🔵🔵🔵🔵🔵🔵🔵

Found 1 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants