fix: make tags accessible to callers of signerootreader #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A quirk of the interface for lazily reading the root seal blobs prevented the blob tags from being available to the caller of ReadLogicalContext. This also now works consistently for all methods on the signed root reader which use this method internaly. Rather than egregiously break an existing public interface, and also because it seems cleaner, we just save the last context read and provide a method to retrieve it if wanted. The method to retrieve will error if the context hasn't been read at all. AB#9570
honourfish
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quirk of the interface for lazily reading the root seal blobs prevented the blob tags from being available to the caller of ReadLogicalContext.
This also now works consistently for all methods on the signed root reader which use this method internaly.
Rather than egregiously break an existing public interface, and also because it seems cleaner, we just save the last context read and provide a method to retrieve it if wanted.
The method to retrieve will error if the context hasn't been read at all.
AB#9570