Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/jgough/10216 support eventsv1 #41

Merged
merged 17 commits into from
Jan 21, 2025
Merged

Dev/jgough/10216 support eventsv1 #41

merged 17 commits into from
Jan 21, 2025

Conversation

honourfish
Copy link
Contributor

@honourfish honourfish commented Jan 17, 2025 •
edited
Loading

Overview

  • consoludated the event reader to be able to read assetsv2 and eventsv1 events
  • use the log verification inclusion verification code.

Testing

  • Working unit, integration and system tests

TODO

  • once we have prod eventv1 events against merklelog, add testing for their verification.

eccles
eccles reviewed Jan 17, 2025
View reviewed changes
app/app.go Show resolved Hide resolved
wp0pw
wp0pw reviewed Jan 20, 2025
View reviewed changes
app/readappdata.go Outdated Show resolved Hide resolved
wp0pw
wp0pw reviewed Jan 20, 2025
View reviewed changes
ediag.go Show resolved Hide resolved
@honourfish honourfish requested review from wp0pw and henry739 January 21, 2025 09:25
wp0pw
wp0pw previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@wp0pw wp0pw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

henry739
henry739 reviewed Jan 21, 2025
View reviewed changes
app/app.go Show resolved Hide resolved
henry739
henry739 reviewed Jan 21, 2025
View reviewed changes
app/app.go Show resolved Hide resolved
henry739
henry739 reviewed Jan 21, 2025
View reviewed changes
app/app.go Show resolved Hide resolved
henry739
henry739 reviewed Jan 21, 2025
View reviewed changes
app/app.go Show resolved Hide resolved
henry739
henry739 reviewed Jan 21, 2025
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
henry739
henry739 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@henry739 henry739 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Some minors deferred to a future TD fixup

@honourfish honourfish merged commit 9835c1c into main Jan 21, 2025
3 checks passed
@honourfish honourfish deleted the dev/jgough/10216-support-eventsv1 branch January 21, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eccles eccles eccles left review comments

@henry739 henry739 henry739 approved these changes

@wp0pw wp0pw wp0pw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@honourfish @eccles @wp0pw @henry739