Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.1 install_requires has incompatible requirements with CKAN 2.10 (ckanserviceprovider) #144

Open
pdelboca opened this issue Jun 18, 2024 · 1 comment

Comments

@pdelboca
Copy link

Describe the bug
Installing datapusher-plus=1.0.1 installs SQLAlchemy-1.3.24 and Flask-Login 0.6.1 which both are incompatible with core CKAN.

Trying to run CKAN after installing datapusher-plus will raise an error:

ImportError: cannot import name 'Row' from 'sqlalchemy.engine' (/home/pdelboca/Repos/ckan/.venv/lib/python3.11/site-packages/sqlalchemy/engine/__init__.py)

To Reproduce
Steps to reproduce the behavior:

  1. Have a CKAN 2.10 installation (with virtual environment)
  2. Clone datapusher-plus
  3. Navigate to datapusher-plus
  4. Install the extension in the virtual environment pip install .
  5. Run CKAN

Expected behavior
Installing datapusher-plus does not install incompatible requirements with CKAN.

@pdelboca
Copy link
Author

@jqnatividad @tino097 I'm happy to create a PR for this issue with some guidance.

I think the only problem is that ckanserviceprovider == 1.2.0 is sill listed in install_requires but I'm not sure if this has more implications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant