Fix install_requires dependencies #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tino097 @jqnatividad I'm creating this PR to fix #144 . If Example:
|
|
thanks, @pdelboca. im working on a code cleanups and configuration declaration. Currently, im on a week off, and i will check this next week |
|
hey @pdelboca can you switch this to dev-v1.0 branch as master is still working as a separate service. My plan is to wait until we are ready for v.1.1.0 and merge dev branch into master @jqnatividad ^^ |
|
@tino097 okay! I will rebase this and start from dev-v1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since
v1.0.0it is no longer required to haveckanserviceproviderasdatapusher-plusis now designed to work as a normal CKAN plugin.This PR cleans leftovers in the
setup.pyfile that are causing errors when installing with CKAN 2.10 (#144 )