fetch & fetchpost: apply clippy::ref_option suggestion to cached …

…functions
dathere · Oct 6, 2024 · 927f1e2 · 927f1e2
1 parent baa479b
commit 927f1e2
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/src/cmd/fetch.rs b/src/cmd/fetch.rs
@@ -798,7 +798,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
                         &url,
                         &client,
                         &limiter,
-                        &jql_selector,
+                        jql_selector.as_ref(),
                         args.flag_store_error,
                         args.flag_pretty,
                         include_existing_columns,
@@ -816,7 +816,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
                         &url,
                         &client,
                         &limiter,
-                        &jql_selector,
+                        jql_selector.as_ref(),
                         args.flag_store_error,
                         args.flag_pretty,
                         include_existing_columns,
@@ -838,7 +838,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
                         &url,
                         &client,
                         &limiter,
-                        &jql_selector,
+                        jql_selector.as_ref(),
                         args.flag_store_error,
                         args.flag_pretty,
                         include_existing_columns,
@@ -878,7 +878,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
                         &url,
                         &client,
                         &limiter,
-                        &jql_selector,
+                        jql_selector.as_ref(),
                         args.flag_store_error,
                         args.flag_pretty,
                         include_existing_columns,
@@ -1025,7 +1025,7 @@ fn get_cached_response(
     url: &str,
     client: &reqwest::blocking::Client,
     limiter: &governor::RateLimiter<NotKeyed, InMemoryState, DefaultClock, NoOpMiddleware>,
-    flag_jql: &Option<String>,
+    flag_jql: Option<&String>,
     flag_store_error: bool,
     flag_pretty: bool,
     include_existing_columns: bool,
@@ -1073,7 +1073,7 @@ fn get_diskcache_response(
     url: &str,
     client: &reqwest::blocking::Client,
     limiter: &governor::RateLimiter<NotKeyed, InMemoryState, DefaultClock, NoOpMiddleware>,
-    flag_jql: &Option<String>,
+    flag_jql: Option<&String>,
     flag_store_error: bool,
     flag_pretty: bool,
     include_existing_columns: bool,
@@ -1123,7 +1123,7 @@ fn get_redis_response(
     url: &str,
     client: &reqwest::blocking::Client,
     limiter: &governor::RateLimiter<NotKeyed, InMemoryState, DefaultClock, NoOpMiddleware>,
-    flag_jql: &Option<String>,
+    flag_jql: Option<&String>,
     flag_store_error: bool,
     flag_pretty: bool,
     include_existing_columns: bool,
@@ -1170,7 +1170,7 @@ fn get_response(
     url: &str,
     client: &reqwest::blocking::Client,
     limiter: &governor::RateLimiter<NotKeyed, InMemoryState, DefaultClock, NoOpMiddleware>,
-    flag_jql: &Option<String>,
+    flag_jql: Option<&String>,
     flag_store_error: bool,
     flag_pretty: bool,
     include_existing_columns: bool,

diff --git a/src/cmd/fetchpost.rs b/src/cmd/fetchpost.rs
@@ -725,7 +725,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
                         &form_body_jsonmap,
                         &client,
                         &limiter,
-                        &jql_selector,
+                        jql_selector.as_ref(),
                         args.flag_store_error,
                         args.flag_pretty,
                         args.flag_compress,
@@ -745,7 +745,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
                         &form_body_jsonmap,
                         &client,
                         &limiter,
-                        &jql_selector,
+                        jql_selector.as_ref(),
                         args.flag_store_error,
                         args.flag_pretty,
                         args.flag_compress,
@@ -769,7 +769,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
                         &form_body_jsonmap,
                         &client,
                         &limiter,
-                        &jql_selector,
+                        jql_selector.as_ref(),
                         args.flag_store_error,
                         args.flag_pretty,
                         args.flag_compress,
@@ -811,7 +811,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
                         &form_body_jsonmap,
                         &client,
                         &limiter,
-                        &jql_selector,
+                        jql_selector.as_ref(),
                         args.flag_store_error,
                         args.flag_pretty,
                         args.flag_compress,
@@ -961,7 +961,7 @@ fn get_cached_response(
     form_body_jsonmap: &serde_json::Map<String, Value>,
     client: &reqwest::blocking::Client,
     limiter: &governor::RateLimiter<NotKeyed, InMemoryState, DefaultClock, NoOpMiddleware>,
-    flag_jql: &Option<String>,
+    flag_jql: Option<&String>,
     flag_store_error: bool,
     flag_pretty: bool,
     flag_compress: bool,
@@ -1013,7 +1013,7 @@ fn get_diskcache_response(
     form_body_jsonmap: &serde_json::Map<String, Value>,
     client: &reqwest::blocking::Client,
     limiter: &governor::RateLimiter<NotKeyed, InMemoryState, DefaultClock, NoOpMiddleware>,
-    flag_jql: &Option<String>,
+    flag_jql: Option<&String>,
     flag_store_error: bool,
     flag_pretty: bool,
     flag_compress: bool,
@@ -1067,7 +1067,7 @@ fn get_redis_response(
     form_body_jsonmap: &serde_json::Map<String, Value>,
     client: &reqwest::blocking::Client,
     limiter: &governor::RateLimiter<NotKeyed, InMemoryState, DefaultClock, NoOpMiddleware>,
-    flag_jql: &Option<String>,
+    flag_jql: Option<&String>,
     flag_store_error: bool,
     flag_pretty: bool,
     flag_compress: bool,
@@ -1098,7 +1098,7 @@ fn get_response(
     form_body_jsonmap: &serde_json::Map<String, Value>,
     client: &reqwest::blocking::Client,
     limiter: &governor::RateLimiter<NotKeyed, InMemoryState, DefaultClock, NoOpMiddleware>,
-    flag_jql: &Option<String>,
+    flag_jql: Option<&String>,
     flag_store_error: bool,
     flag_pretty: bool,
     flag_compress: bool,