Refactor and expose cache_fragment_metadata() as api #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ng_perf_11142024 #178 +/- ##
====================================================
+ Coverage 63.93% 64.04% +0.11%
====================================================
Files 58 58
Lines 16425 16446 +21
Branches 2951 2960 +9
====================================================
+ Hits 10501 10533 +32
+ Misses 5793 5783 -10
+ Partials 131 130 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
mlathara
approved these changes
Nov 22, 2024
| } | ||
| free(buffer); | ||
| if (unlock_file(fd)) { | ||
| RETURN_ERRMSG_PATH("Could not close file", bookkeeping_path); |
There was a problem hiding this comment.
Do we need to delete the file for cleanup in this case?
nalinigans
added a commit
that referenced
this pull request
Nov 23, 2024
…ays (#177) * Support caching of bookkeeping files locally for cloud workspaces/arrays * remove azurite for now, needs new certificates * Codecov now needs token even for public repositories * Test TILEDB_CACHE and TILEDB_BOOKKEEPING_STATS flows * Add tests for code coverage * Refactor and expose cache_fragment_metadata() as api (#178) * Add cache_fragment_metadata to TileDBUtils to expose this functionality as api * Don't leak file handles in error conditions * Copyright update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cache_fragment_metadata to TileDBUtils to expose this functionality as api.