Added code to support monitoring of 2 meters #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added variable to specify number of meters
Added variable to specify number of meters
Added information regarding the variable to specify the number of meters
Added variable to specify number of meters
Added code to support 2 meters. Allows for the monitoring of a consumption meter in addition to the production meter typically present by default in the SE inverters.
Added code to support a second meter
|
Kudos, SonarCloud Quality Gate passed!
|
|
@cooldil Thanks for the PR, though I think if multiple meters is a scenario (I don't have any), do you know how many meters are supported? Rather than duplicating all the code, it would probably be better to use string templates in a for loop for the meters based on the configured quantity |
|
@dave92082 this really insightful Fronius talk on sunspec integration mentions 4 meters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.