Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show the detail in lua table array part #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huanzai
Copy link

@huanzai huanzai commented Nov 27, 2024

In lua, we need to use both indexed and named filter which to get the detail of table

@daveleroy
Copy link
Owner

daveleroy commented Nov 28, 2024

This looks like it requests all variables using the paged api which is explicitly not supported by this client and is broadcast to the adapter with supportsVariablePaging: False. If you want to support paging you should add real support for paging not request all variables using filters and paged requests.

What adapter are you trying to support? This adapter is off spec and should be fixed on the adapter side

@huanzai
Copy link
Author

huanzai commented Nov 28, 2024

Ok, I got, I will fix the adapter.

@daveleroy
Copy link
Owner

Here is the relevant parts of the protocol.

  /**
   * Filter to limit the child variables to either named or indexed. If omitted,
   * both types are fetched.
   * Values: 'indexed', 'named'
   */
  filter?: 'indexed' | 'named';

  /**
   * The index of the first variable to return; if omitted children start at 0.
   * The attribute is only honored by a debug adapter if the corresponding
   * capability `supportsVariablePaging` is true.
   */
  start?: number;

  /**
   * The number of variables to return. If count is missing or 0, all variables
   * are returned.
   * The attribute is only honored by a debug adapter if the corresponding
   * capability `supportsVariablePaging` is true.
   */
  count?: number;

All these values can be omitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants