Refactor CSS.FontFamilyName.t: Add Union Types for Unquoted Generic Families
#544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
davesnx
approved these changes
Mar 7, 2025
| | `Emoji => [%expr `emoji] | ||
| | `Math => [%expr `math] | ||
| | `Fangsong => [%expr `fangsong] | ||
| | `_apple_system => [%expr `custom("-apple-system")]; |
There was a problem hiding this comment.
apple-system isn't custom isn't it?
I believe is the old system-ui, but it shouldn't have the quotes
There was a problem hiding this comment.
you are right, I thought it was a font-name
| | `emoji | ||
| | `math | ||
| | `fangsong | ||
| | `custom of string |
There was a problem hiding this comment.
Did you thought about another name rather than "custom"?
quoted or string comes to mind and feels cleaner. This is rather a nitpick
There was a problem hiding this comment.
named or specific came to mind but will stick to quoted - 6058cc5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the type definition for
CSS.Types.FontFamilyName.tto allow using unquoted generic font family names directly in the code. Currently, only a string is accepted, forcing generic names like "monospace" to be quoted, which isn’t ideal for specifying static defaults.