Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jedi-core passing sys_path from jediepcserver.py #1973

Closed
wants to merge 1 commit into from

Conversation

plandes
Copy link

@plandes plandes commented Dec 2, 2023

The Emacs Jedi library creates a jedi.Script with a sys_path parameter. It appears this was removed in a more recent version. I have added the parameter to the class initializer and added any non-None paths to the Python sys.path list.

This fixes pip package versions higher than 0.17.2 for my set, which is:
Emacs: 29.1
Jedi: 0.3.0
Python: 3.11.6
epc: 0.0.5
sexpdata: 1.0.0

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f8e502f) 94.50% compared to head (67618fb) 94.43%.

❗ Current head 67618fb differs from pull request most recent head ebbb9bc. Consider uploading reports for the commit ebbb9bc to get more accurate results

Files Patch % Lines
jedi/api/__init__.py 33.33% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1973      +/-   ##
==========================================
- Coverage   94.50%   94.43%   -0.08%     
==========================================
  Files          80       80              
  Lines       11917    11922       +5     
==========================================
- Hits        11262    11258       -4     
- Misses        655      664       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidhalter
Copy link
Owner

This was intentionally removed (see also https://jedi.readthedocs.io/en/latest/docs/changelog.html#id8)

Use the Project API to configure sys paths now: https://jedi.readthedocs.io/en/latest/docs/api.html#projects

@plandes
Copy link
Author

plandes commented Dec 2, 2023

@davidhalter Thanks for the quick response. I'll try to address the issue from the Emacs library side. Thanks for writing this great library.

-Paul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants