Fix compatibility with pytest 8 #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! |
PeterJCLaw
reviewed
May 23, 2024
| @@ -12,7 +12,7 @@ class TestSetupReadline(unittest.TestCase): | |||
| class NameSpace(object): | |||
| pass | |||
|
|
|||
| def __init__(self, *args, **kwargs): | |||
| def setUp(self, *args, **kwargs): | |||
| super().__init__(*args, **kwargs) | |||
There was a problem hiding this comment.
Should the call to super() not also be changed to super().setUp(*args, **kwargs)?
There was a problem hiding this comment.
Oh thanks Peter! Yes that would be a very welcome change. I suspect this is just an oversight...
There was a problem hiding this comment.
The rename proposed here was to make the pytest call the method automatically. I think it's fine to call init in the setUp method. I don't have a strong opinion.
There was a problem hiding this comment.
I added 065580b. I feel like it's both fine to call super there or call nothing at all. But it feels very wrong to call __init__ from setUp. I'm pretty sure that was called before setUp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1995