Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add semantic release simulation docs #608

Merged
merged 1 commit into from
May 26, 2024

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented May 26, 2024

Issue or need

In latest release, main was added as dist-tag to the package. But latest wasn't.

About main dist tag, it's because an error in Semantic Release configuration. channel defines the tag used when publishing in npm. And by default it takes the name of the branch (unless it's the first release branch). So that's why main as there. It has been there since the beginning, after checking git notes created by semantic release and GitHub Actions logs.

About latest not being there, still don't know why exactly*. Nothing in semantic release or the npm plugin seems to have changed to alter that behavior. Makes sense, as it would be a breaking change and therefore a documented one. It was there for previous releases. Though that may change soon in npm v11.

To be able to find that, simulated releases with semantic release. It's not an easy task though and has its quirks. The more the further you want to simulate. So writing them in a guide in case a release needs to be debugged or rehearsed in the future.

Tried to create a script for releases rehearsal but there are so many quirks and things can go so wrong that script would be very complex. Better to rely on human intel for now.

*Maybe this whole thing came because I didn't properly hit Cmd + Shift + R 😆 Or cache. It's always the cache 😛

Proposed changes

Document the release rehearsal steps. In CONTRIBUTING.md where all processes are explained.

Will manually fix the invalid semantic release notes (should be in null / default channel instead of main channel) and semantic release configuration manually after merging this PR. Now that can first safely ensure the proper release config will be in place.

Quick reminders

  • 🤝 I will follow Code of Conduct
  • No existing pull request already does almost same changes
  • 👁️ Contributing docs are something I've taken a look at
  • 📝 Commit messages convention has been followed
  • 💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • 🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • ⚙️ API Report has been updated if API surface is altered.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

@davidlj95 davidlj95 enabled auto-merge (squash) May 26, 2024 21:40
@davidlj95 davidlj95 merged commit 1f162bc into main May 26, 2024
24 checks passed
@davidlj95 davidlj95 deleted the stacked/build-dry-run-semantic-release branch May 26, 2024 21:42
Copy link

📦 Bundle size (Angular v15)

Git ref: db735c0a3bc0f9e8026ffbe150b175a34bfe07f0

Module file Size Base size Difference
ngx-meta-core.mjs 3501 bytes (3.5KiB) 3501 bytes (3.5KiB) No change
ngx-meta-json-ld.mjs 386 bytes (386B) 386 bytes (386B) No change
ngx-meta-open-graph.mjs 1220 bytes (1.2KiB) 1220 bytes (1.2KiB) No change
ngx-meta-routing.mjs 1009 bytes (1009B) 1009 bytes (1009B) No change
ngx-meta-standard.mjs 885 bytes (885B) 885 bytes (885B) No change
ngx-meta-twitter-card.mjs 641 bytes (641B) 641 bytes (641B) No change
Total 7642 bytes (7.5KiB) 7642 bytes (7.5KiB) No change

Copy link

📦 Bundle size (Angular v18)

Git ref: db735c0a3bc0f9e8026ffbe150b175a34bfe07f0

Module file Size Base size Difference
ngx-meta-core.mjs 3094 bytes (3.1KiB) 3094 bytes (3.1KiB) No change
ngx-meta-json-ld.mjs 226 bytes (226B) 226 bytes (226B) No change
ngx-meta-open-graph.mjs 869 bytes (869B) 869 bytes (869B) No change
ngx-meta-routing.mjs 839 bytes (839B) 839 bytes (839B) No change
ngx-meta-standard.mjs 768 bytes (768B) 768 bytes (768B) No change
ngx-meta-twitter-card.mjs 470 bytes (470B) 470 bytes (470B) No change
Total 6266 bytes (6.2KiB) 6266 bytes (6.2KiB) No change

Copy link

📦 Bundle size (Angular v17)

Git ref: db735c0a3bc0f9e8026ffbe150b175a34bfe07f0

Module file Size Base size Difference
ngx-meta-core.mjs 3094 bytes (3.1KiB) 3094 bytes (3.1KiB) No change
ngx-meta-json-ld.mjs 226 bytes (226B) 226 bytes (226B) No change
ngx-meta-open-graph.mjs 869 bytes (869B) 869 bytes (869B) No change
ngx-meta-routing.mjs 839 bytes (839B) 839 bytes (839B) No change
ngx-meta-standard.mjs 768 bytes (768B) 768 bytes (768B) No change
ngx-meta-twitter-card.mjs 470 bytes (470B) 470 bytes (470B) No change
Total 6266 bytes (6.2KiB) 6266 bytes (6.2KiB) No change

Copy link

📦 Bundle size (Angular v16)

Git ref: db735c0a3bc0f9e8026ffbe150b175a34bfe07f0

Module file Size Base size Difference
ngx-meta-core.mjs 3501 bytes (3.5KiB) 3501 bytes (3.5KiB) No change
ngx-meta-json-ld.mjs 386 bytes (386B) 386 bytes (386B) No change
ngx-meta-open-graph.mjs 1220 bytes (1.2KiB) 1220 bytes (1.2KiB) No change
ngx-meta-routing.mjs 1009 bytes (1009B) 1009 bytes (1009B) No change
ngx-meta-standard.mjs 885 bytes (885B) 885 bytes (885B) No change
ngx-meta-twitter-card.mjs 641 bytes (641B) 641 bytes (641B) No change
Total 7642 bytes (7.5KiB) 7642 bytes (7.5KiB) No change

Copy link

🎉 This PR is included in version 1.0.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant