PR for #7: jax-maven-plugin cannot find extensions on unix #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… maven property declaration
|
Thanks @jenskreidler, does this fix the problem on Unix? |
|
Yes it does. However, I wonder why the issue doesn't arise on windows |
I agree, that's surprising. Are you running zulu jvm on windows too? |
|
Yes, in both environments using zulu-11 |
|
I'm happy to merge this and move on. I guess if we were going to do this properly though I would grab your failing test case and try it on my openjdk environments on Solaris and Linux. Up to you. |
|
Thanks Dave, for me this ClassNotFound issue coming from the JSE Service-Loader mechanism is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added runtime dependencies for the slf4j-api and its simple implementation. Depending on owners preferences, omit slf4j-simple (causes "Failed to load class org.slf4j.impl.StaticLoggerBinder" warnings), add slf4j-nop or do nothing here.