Update gem to use ActiveSupport >= 7.0 #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to this comment [1] we need to load the whole of active_support and cannot load the tagged_logging class individually. [1] rails/rails#47733 (comment)
To clarify a bit, |
|
What are we gaining from this? Is the older version breaking something? |
|
I'm not sure about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates this gem to support the latest ActiveSupport version v7.0.4.3
In order to do this we need to fix a namespacing issue in Rails/ActiveSupport rails/rails#47733To demonstrate that the fix in the linked PR works, I created a proof-of-concept monkeypatching theActiveSupport::TaggedLoggingclass with a local copy. I will update this PR to remove the monkey-patched version once the PR to Rails is merged.It turns out we "simply" need to load active_support to use the individual classes.