Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Array mutations #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for Array mutations #23

wants to merge 1 commit into from

Conversation

AlexWayfer
Copy link
Contributor

It's like experimental and debatable, but looks cool for me.

@AlexWayfer
Add support for Array mutations
57f1623 
It's like experimental and debatable, but looks cool for me.
@coveralls
Copy link

coveralls commented Jul 12, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 99.886% when pulling 57f1623 on AlexWayfer:support_array_mutations into b57d637 on davydovanton:master.

davydovanton
davydovanton requested changes Jul 14, 2018
View reviewed changes
Copy link
Owner

@davydovanton davydovanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, thanks for PR. Idea looks cool in general, but I suggest to use optional mutation array. For example:

attribute :books, MutableArray, of: Book

# or

attribute :books, Array, of: Book

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davydovanton davydovanton davydovanton requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexWayfer @coveralls @davydovanton