-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building a DuckDB Playground with Daytona #117
Conversation
You mind reviewing this PR too @mojafa ? |
@c0d33ngr here's my review:
![]() ![]() ![]() ![]() ![]() ![]() ![]() Please fix the issues. |
@mojafa thanks for the review. I'll fix them |
Please assign me to the issue @mojafa |
Done |
@c0d33ngr any updates? |
Hi @mojafa sorry for the delays I think I've updated most of the issues you found in the PR. The one remaining ones should be the broken links |
@mojafa I think what you meant of broken link or raw reference is as a result of the spacing between some Some markdown files in Datyona definition directory has spacing between their names and including dashes or underscore won't point to the file in Daytona CMS - I think so |
@mojafa what do you think? |
@c0d33ngr please fix these 👆🏽 |
@mojafa I've fixed them with |
@c0d33ngr this PR fails DCO checks |
oh.. I did it from GitHub web with my phone |
please fix |
Take your time, don't be in a hurry. Quality of speed |
@c0d33ngr also please run: but mostly here:
Formatting and Style Errors
|
@c0d33ngr any updates? |
Just got access to my PC, wrapping everything up ASAP Thanks for your patience |
Any tool to automate the fix? |
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
Signed-off-by: Jeffrey <[email protected]>
fb3011b
to
dd3913d
Compare
The tests are green now @mojafa |
![]() @c0d33ngr so far so good, I managed to setup well. however on this section
there's no output as you could see in my screenshot above. However please note that when running Python scripts that generate visualizations inside a Docker container or a headless environment (like your devcontainer), you might not see the plots display on your screen because there's no graphical user interface (GUI) available to render them. the solution is to
add this line |
@c0d33ngr just that minor fix add |
Signed-off-by: Jeffrey <[email protected]>
Done it 💯 |
Awesome. |
Anything I need to do for it to be merged? @mojafa |
Will be merged, i've shared already |
Alright... Thank you I'm already writing to close another issue. I was worried for this PR as I don't like having multiple PRs opened |
Writer's Checklist
Writing Structure
code elements
andMarkdown format
where appropriate.Fact-Checking
Asset Management
/assets
folder.YYYYMMDD_title_of_the_article_IMG_NAME_NO.png
.Interlinking
CTRL+F
to search for relevant keywords in:Glossary/Definitions
/defitnitions
folder.Review and Edit