-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting Up a Python Dev Environment with DevContainers and Daytona #120
Conversation
Signed-off-by: Kiran1689 <[email protected]>
@mojafa Can you please review? |
Signed-off-by: Kiran1689 <[email protected]>
@Kiran1689 your guide works. fix the requests then we can merge. |
@mojafa The image is not showing for the issue can you please reshare |
@Kiran1689 Here: |
Signed-off-by: Kiran1689 <[email protected]>
updated @mojafa |
Anything else @mojafa ?? |
@Kiran1689 sorry I think my previous comments hadn't gone through. see below. |
only have this guide and the template as well as the assets, including author section as well |
@mojafa Sorry, I didn't get that. What I need to remove? Can you please tell My branch is up to date with the main branch.. As the main repo already contains my author details, I didn't add to this PR again. This PR only has a guide file for issue #10 and assets related to it. No other guide files.. My other contributions are already merged into the main branch. |
@mojafa You can check the files added for this PR here - https://github.com/daytonaio/content/pull/120/files This PR contains only files related to the issue, no other contribution files. |
@mojafa Can you check this |
@Kiran1689 on it |
@nkkko PR meets all requirements but is failing on content complaince |
@nkkko Can you please look into this? |
Now, your python dev environmentis ready to use. | ||
|
||
### Step 3: Confirmation | ||
Now, In your VS code run the test cases, you will see all the testcases passed. This means python dev environment has successfull set for your project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code!
- [Daytona Documentation](https://www.daytona.io/dotfiles/the-ultimate-guide-to-managing-python-environments) | ||
|
||
|
||
<!-- Note on Definitions --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mojafa please take more attention, notes should be removed
![Daytona workspace](assets/setting_up_a_python_dev_environment_with_devcontainers_and_daytona_img10.png) | ||
|
||
## Conclusion | ||
By following this guide, you've set up a fully containerized Python development environment using Daytona and DevContainers. This setup ensures that your projects are reproducible, isolated, and consistent across machines, enabling smooth collaboration and effortless debugging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the right way of writing Dev Container not DevContainer
@mojafa this doesn't read 100% well, there are still some small things you should have caught 😁 |
Signed-off-by: Kiran1689 <[email protected]>
@nkkko 👀 |
Will rereview |
@Kiran1689 quite a lot of It's still failing on compliance checks.
|
@Kiran1689 please refer to the issue again.
Use this link for inspiration: https://www.daytona.io/dotfiles/the-ultimate-guide-to-managing-python-environments |
Signed-off-by: Kiran1689 <[email protected]>
Signed-off-by: Kiran1689 <[email protected]>
|
|
@Kiran1689 also please run: but mostly here:
Formatting and Style Errors
|
Signed-off-by: Kiran1689 <[email protected]>
Signed-off-by: Kiran1689 <[email protected]>
Signed-off-by: Kiran1689 <[email protected]>
Signed-off-by: Kiran1689 <[email protected]>
@mojafa, I've updated the content to correct grammar and spelling mistakes and resolved all lint issues in my guide. However, it’s still failing due to lint issues in other files, including node modules. Can't fix that. I noticed that all other PRs are failing the Content Compliance Check. |
Signed-off-by: Kiran1689 <[email protected]>
Signed-off-by: Kiran1689 <[email protected]>
@mojafa Now it's passing all checks, waiting for your approval.. |
@Kiran1689 here's my feedback: Terminology Corrections: "DevContainer" vs. "Dev Container": The correct term is "Dev Container." Please update all instances of "DevContainer" to "Dev Container" throughout the article to maintain accuracy. Spacing Around Links: Lack of Detailed Instructions: Example: Sections like "## Step 1: Preparations" and "### Fork the Template Repository" are brief and do not provide enough detailed steps for a reader to follow effectively. Recommendation: Consider following a structure similar to https://www.daytona.io/dotfiles/the-ultimate-guide-to-managing-python-environments . This guide offers detailed, step-by-step instructions that would greatly benefit readers. Incomplete Steps: In "### Step 3: Confirmation," the instructions are vague: Rework Section Headings: The current headings like "## Step 1: Preparations" can be made more descriptive. For example: "## Step 1: Setting Up Your Development Environment" |
you could use this merged PR as inspiration: https://github.com/daytonaio/content/pull/85/files I'd also suggest, you let users create a new repo and then guide them on it step by step. |
Good stuff so far, you just picked a short cut, it's a guide, take your time and be very technical as it's a technical guide. |
Hey @mojafa You are reviewing the old files.. Check here always for the latest committed Most of them are already fixed.. |
I'll work on this |
Hey @Kiran1689 I created a new workspace by using Interestingly I'm still seeing the same stuff. See below: |
Signed-off-by: Kiran1689 <[email protected]>
Signed-off-by: Kiran1689 <[email protected]>
@Kiran1689 This is what I'm talking about now. The guide is comprehensive and covers all the points. Thank you. |
@mojafa can you please provide your approval if everything is good.. |
@nkkko Can you please check this? |
@Kiran1689 please be patient |
fix #10
/claim #10
Writer's Checklist
Writing Structure
code elements
andMarkdown format
where appropriate.Fact-Checking
Asset Management
/assets
folder.YYYYMMDD_title_of_the_article_IMG_NAME_NO.png
.Interlinking
CTRL+F
to search for relevant keywords in:Glossary/Definitions
/defitnitions
folder.Review and Edit