Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat:Added the article on application of containerization development #18

Closed
wants to merge 2 commits into from
Closed

Feat:Added the article on application of containerization development #18

wants to merge 2 commits into from

Conversation

Mubashirshariq
Copy link

@Mubashirshariq Mubashirshariq commented Aug 19, 2024 •
edited
Loading

Pull Request Template

/claim #7
/closed #7

Writer's Checklist

  • Follow Writing Structure

    • I have used more than two H2 subtitles to organize content.
    • Include an introduction with at least two paragraphs before the first H2 section.
    • Use bold, italic, underline, notes, quotes, TLDRs, and key points as needed.
    • Include code elements where appropriate.
    • Write the article in Markdown format.

  • Fact-Check

    • I have verified all facts and data points included in the article.

  • Assets

    • Save images in the /assets folder.
    • Follow naming conventions: YYYYMMDD_title_of_the_article_IMG_NAME_NO.png.

  • Interlinking

  • Glossary/Definitions

    • Identify and mark new terms that could be added to the Definitions page.

  • Review and Edit

    • Read the article out loud to catch any awkward phrasing.
    • Run the draft through Grammarly or a similar tool to correct grammar and spelling errors.
    • Double-check adherence to the style guide and repository guidelines.

@algora-pbc algora-pbc bot mentioned this pull request Aug 19, 2024
Closed
@nkkko
Copy link
Member

nkkko commented Aug 20, 2024 •
edited
Loading

I can't review until you implement the checklist and DCO. Reread the README, you haven't followed it closely. The article is messy mashup of AI outputs. Effort 1/10.

@Mubashirshariq Mubashirshariq force-pushed the Applications-of-Containerized-Development branch 6 times, most recently from 7d1f267 to 76ee651 Compare August 21, 2024 11:58
nkkko
nkkko requested changes Aug 22, 2024
View reviewed changes
Copy link
Member

@nkkko nkkko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

article is a hot mess, but you could do something out of it.... please invest more time!!!! thanks

articles/20240819.md Outdated

### Company Profile

**About The Warehouse Group**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when using content from others, in this case Docker case study, you should do it properly, reference docker source and write it as such... as evident from the case study done by Docker The Warehous .... has ...what... why... how

articles/20240819.md

The Warehouse Group’s successful implementation of Docker has transformed their development and deployment practices, resulting in increased efficiency, cost savings, and faster feature delivery. By embracing containerization, The Group has solidified its position at the forefront of the retail industry and continues to drive innovation in its development processes.

---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

articles/20240819.md Outdated

### Nuware's Containerization Journey

### Download Case Study
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is messy

articles/20240819.md Outdated

### Key Highlights

- **Application Portability:** Containers package applications and their dependencies together, ensuring they run consistently across different environments and platforms, enhancing portability.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is hard to read, the following h3 sections

articles/20240819.md Outdated
---


### Code Example
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this now?

@Mubashirshariq
added the article on containerization case studies and lesson learned
c52d52e 
strucutured it according to readme

Signed-off-by: Mubashir  Shariq <[email protected]>
@Mubashirshariq
made required changes
79b4779 
Signed-off-by: Mubashir  Shariq <[email protected]>
@Mubashirshariq Mubashirshariq force-pushed the Applications-of-Containerized-Development branch from f6aac33 to 79b4779 Compare August 23, 2024 05:56
@Mubashirshariq
Copy link
Author

@nkkko I have made the required changes,plz review ,Thanks!

@Mubashirshariq Mubashirshariq requested a review from nkkko September 2, 2024 13:41
@nkkko
Copy link
Member

nkkko commented Sep 10, 2024

This is better but needs more work, please answer to all my comments to make it easier for me to understand what you did. Also you haven't add reference to the mention case study, and that case study is half of the article. Please reduce it and invest more effort. THanks

@mojafa
Copy link
Collaborator

mojafa commented Dec 2, 2024

@Mubashirshariq there's quite a lot to be done.

first off your article fails to address the issue: #7

Insights into team workflows, onboarding processes, and long-term benefits.

also there's a lot of unneccessary spacing and linting issues.

Please redo it and check the CONTRIBUTING.md file and resubmit your article. Be sure toinclude image assets and refrences, as well as rename the article title.

@mojafa
Copy link
Collaborator

mojafa commented Dec 22, 2024

@Mubashirshariq any updates?

@mojafa
Copy link
Collaborator

mojafa commented Dec 30, 2024

@Mubashirshariq any updates?

@mojafa
Copy link
Collaborator

mojafa commented Jan 31, 2025

@Mubashirshariq Thanks for your contribution and discussion on this issue! We're doing some cleanup to keep the repo focused, and we've closed the issue this PR addresses for now. Appreciate your support! 🙏

@mojafa mojafa closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkkko nkkko Awaiting requested review from nkkko

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Real-World Applications of Containerized Development: Case Studies and Lessons Learned
3 participants
@Mubashirshariq @nkkko @mojafa