-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: How to contribute devcontainer.json to repo #42
base: main
Are you sure you want to change the base?
Feat: How to contribute devcontainer.json to repo #42
Conversation
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe. |
…and use it Signed-off-by: Dheeraj Singh <[email protected]>
Signed-off-by: Dheeraj Singh <[email protected]>
Signed-off-by: Dheeraj Singh <[email protected]>
e11cede
to
13a0fff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the other article from this PR
have you tested the devcontainer locally with VS Code and Daytona?
have you opened PR on groq repo to contribute devcontainer?
please read the readme and follow the checklist if you fail to follow the checklist I would be forced to close the PR (for example you have selected that you have put imgs int oassets and that you have done interlinking, not true)
thanks!
Signed-off-by: Dheeraj Singh <[email protected]>
@nkkko I made the requested changes. Kindly check it out... |
@nkkko there's no open PR on groq repo or any of the closed PRs that @itsdheerajdp submitted. I'm not sure if we shoudl close this PR. @itsdheerajdp could you please reread the issue and have a go again? I also realised you're attempting multiple issues, please focus on one until it's closed. |
I have read the issue and i updated my PR long ago as per requested changes |
@itsdheerajdp I'll review this PR after your other PR is merged/closed. I've just requested for review |
This PR is updated as requested long before. Try to review it |
@itsdheerajdp you didnt open a PR on groq repo to contribute devcontainer. Again, please read the issue #35 |
/claim #35
Fixes: #35
Writer's Checklist
Follow Writing Structure
code elements
where appropriate.Fact-Check
Assets
/assets
folder.YYYYMMDD_title_of_the_article_IMG_NAME_NO.png
.Interlinking
CTRL+F
to search for relevant keywords on:Glossary/Definitions
Review and Edit