Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: How to contribute devcontainer.json to repo #42

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

itsdheerajdp
Copy link

@itsdheerajdp itsdheerajdp commented Aug 21, 2024

/claim #35
Fixes: #35

Writer's Checklist

  • Follow Writing Structure

    • I have used more than two H2 subtitles to organize content.
    • Include an introduction with at least two paragraphs before the first H2 section.
    • Use bold, italic, underline, notes, quotes, TLDRs, and key points as needed.
    • Include code elements where appropriate.
    • Write the article in Markdown format.
  • Fact-Check

    • I have verified all facts and data points included in the article.
  • Assets

    • Save images in the /assets folder.
    • Follow naming conventions: YYYYMMDD_title_of_the_article_IMG_NAME_NO.png.
  • Interlinking

  • Glossary/Definitions

    • Identify and mark new terms that could be added to the Definitions page.
  • Review and Edit

    • Read the article out loud to catch any awkward phrasing.
    • Run the draft through Grammarly or a similar tool to correct grammar and spelling errors.
    • Double-check adherence to the style guide and repository guidelines.

Copy link

algora-pbc bot commented Aug 21, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@itsdheerajdp itsdheerajdp force-pushed the how_to_contribute_devcontainer.json_to_repo branch from e11cede to 13a0fff Compare August 21, 2024 04:28
Copy link
Member

@nkkko nkkko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the other article from this PR
have you tested the devcontainer locally with VS Code and Daytona?
have you opened PR on groq repo to contribute devcontainer?
please read the readme and follow the checklist if you fail to follow the checklist I would be forced to close the PR (for example you have selected that you have put imgs int oassets and that you have done interlinking, not true)

thanks!

Signed-off-by: Dheeraj Singh <[email protected]>
@itsdheerajdp
Copy link
Author

@nkkko I made the requested changes. Kindly check it out...

@mojafa
Copy link
Collaborator

mojafa commented Dec 2, 2024

@nkkko there's no open PR on groq repo or any of the closed PRs that @itsdheerajdp submitted. I'm not sure if we shoudl close this PR.

@itsdheerajdp could you please reread the issue and have a go again? I also realised you're attempting multiple issues, please focus on one until it's closed.

@itsdheerajdp
Copy link
Author

@nkkko there's no open PR or as well as any of the closed PRs that @itsdheerajdp submitted. I'm not sure if we shoudl close this PR.

@itsdheerajdp could you please reread the issue and have a go again? OI also realised you're attempting multiple issues, please focus on one until it's closed.

I have read the issue and i updated my PR long ago as per requested changes

@mojafa
Copy link
Collaborator

mojafa commented Dec 4, 2024

@itsdheerajdp I'll review this PR after your other PR is merged/closed. I've just requested for review

@itsdheerajdp
Copy link
Author

@itsdheerajdp I'll review this PR after your other PR is merged/closed. I've just requested for review

This PR is updated as requested long before. Try to review it

@mojafa
Copy link
Collaborator

mojafa commented Dec 9, 2024

@itsdheerajdp you didnt open a PR on groq repo to contribute devcontainer.

Again, please read the issue #35
Screenshot 2024-12-09 at 11 00 48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to contribute devcontainer.json to the repo
3 participants