CB-4541 feat: tree filter #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return true; | ||
| } | ||
|
|
||
| let isNodeMatched = treeData.getNode(nodeId).name.toLowerCase().includes(this.filter.toLowerCase()); |
There was a problem hiding this comment.
An idea for the future: we can implement a fuzzy search for all of our filters in the app. it is easy peasy to implement and improves UX experience while searching something
webapp/packages/plugin-navigation-tree/src/TreeNew/DataTransformers/rootTransformers.ts
Show resolved
Hide resolved
webapp/packages/plugin-settings-panel/src/SettingsPanel/SettingsList.tsx
Outdated
Show resolved
Hide resolved
webapp/packages/plugin-settings-panel/src/SettingsPanel/SettingsGroup.tsx
Show resolved
Hide resolved
webapp/packages/plugin-settings-panel/src/SettingsPanel/SettingsList.tsx
Outdated
Show resolved
Hide resolved
sergeyteleshev
approved these changes
Sep 12, 2024
devnaumov
reviewed
Sep 13, 2024
| import { ROOT_SETTINGS_GROUP, type SettingsGroup as SettingsGroupType } from '@cloudbeaver/core-settings'; | ||
| import type { ITreeData } from '@cloudbeaver/plugin-navigation-tree'; | ||
|
|
||
| export function* getGroupsFromTree(treeData: ITreeData, groups: string[]): IterableIterator<SettingsGroupType> { |
There was a problem hiding this comment.
What is the reason for the generator here?
There was a problem hiding this comment.
it's fix for this comment #2908 (comment)
Wroud
force-pushed
the
feat/cb-4541/tree-filter
branch
from
262dd16 to
b18ccfe
Compare
Wroud
force-pushed
the
feat/cb-4541/tree-filter
branch
from
0ba3ad0 to
8c65ffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.