CB-5658 CB-5659 fix: pagination resolving #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnaumov
reviewed
Sep 17, 2024
sergeyteleshev
approved these changes
Sep 18, 2024
Comment on lines
464
to
465
| const pageListKey = this.aliases.isAlias(originalKey, CachedResourceOffsetPageListKey); | ||
| const pageKey = this.aliases.isAlias(originalKey, CachedResourceOffsetPageKey) || pageListKey; |
There was a problem hiding this comment.
I can see a copy-paste here and a little bit below for all resources with pagination.
Maybe we should add a helper here so it returns the correct pageKey and the page? So we don't miss this bug when we create a new feature with the exact pagination mechanism
There was a problem hiding this comment.
now you can use getOffsetPageKeyInfo helper
Comment on lines
+135
to
+140
| for (const page of pageInfo.pages) { | ||
| if (page.isHasCommonSegment(from, to)) { | ||
| for (const pageKey of page.get(from, to)) { | ||
| keys.add(pageKey); | ||
| } | ||
| } |
There was a problem hiding this comment.
Same here. we can define helper like getKeysFromPages(pages)
devnaumov
approved these changes
Sep 18, 2024
sergeyteleshev
approved these changes
Sep 18, 2024
Wroud
added a commit
that referenced
this pull request
Sep 18, 2024
* CB-5658 CB-5659 fix: pagination resolving * CB-5658 fix resources pages * CB-5667 fix: node rename behavior * CB-5658 chore: refactor repeated code --------- Co-authored-by: mr-anton-t <[email protected]> Co-authored-by: Daria Marutkina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.