СB-5796 Metadata/data editor - error when changing server settings #3051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wroud
requested changes
Nov 6, 2024
Comment on lines
107
to
109
| } else { | ||
| } else if (!connection.connected) { | ||
| await this.connectionInfoResource.init({ projectId: key.projectId, connectionId: key.connectionId }); | ||
| } |
There was a problem hiding this comment.
this is not true fix i think, because this change is hides case but not solves the problem.
I suppose that problem is that one of extra requests to inner database resources silently re-opens connection on the backend. We need to investigate this case and solve the problem properly
sergeyteleshev
force-pushed
the
CB-5796-metadata-data-editor-error-when-changing-server-settings
branch
from
f4b3970 to
fc15d5d
Compare
devnaumov
approved these changes
Nov 8, 2024
devnaumov
approved these changes
Nov 8, 2024
| @@ -23,10 +23,11 @@ export const ConnectionShield = observer<PropsWithChildren<IConnectionShieldProp | |||
| const notificationService = useService(NotificationService); | |||
|
|
|||
| const connection = useResource(ConnectionShield, ConnectionInfoResource, connectionKey); | |||
| const connecting = getComputed(() => connectionKey && connection.resource.isConnecting(connectionKey)); | |||
| const connecting = getComputed(() => (connectionKey && connection.resource.isConnecting(connectionKey)) || connection.loading); | |||
| const isConnectionReady = getComputed(() => !connecting && connection.data?.connected && connection.loaded && !connection.outdated); | |||
There was a problem hiding this comment.
Seems like we should implement some general solution for checking whether resource entity is fully available or not. Not now, but maybe in a tech sprint
…nging-server-settings
…nging-server-settings
…nging-server-settings
…nging-server-settings
…nging-server-settings
…nging-server-settings
…nging-server-settings
Wroud
approved these changes
Nov 20, 2024
Wroud
deleted the
CB-5796-metadata-data-editor-error-when-changing-server-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.