New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB-5926 refactor: sort settings by translation #3088

Closed

SychevAndrey wants to merge 1 commit into devel from CB-5926-preferences-sorting

Contributor

SychevAndrey commented Nov 20, 2024

No description provided.


          CB-5926 refactor: sort settings by translation

26935d9

SychevAndrey requested review from Wroud and devnaumov

November 20, 2024 15:16

SychevAndrey self-assigned this

Wroud reviewed

View reviewed changes

webapp/packages/plugin-settings-panel/src/SettingsPanel/useSettings.ts

Comment on lines -30 to +37

-                        .sort((a, b) => a.name.localeCompare(b.name));
+                        .sort((a, b) => {
+                          if (a.type === b.type) {
+                            return translate(a.name).localeCompare(translate(b.name));
+                          } else {
+                            return a.type - b.type;
+                          }
+                        });

Member

Wroud Nov 21, 2024

I'm really not sure that we need to group settings by type because it can look better in a small amount of settings but will be unreadable with many

SychevAndrey closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet