add assert for min image size #331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as segmentation does not work well if images are too low resolution.
breznak
commented
Feb 12, 2020
yolact.py
Outdated
| @@ -215,6 +215,7 @@ def make_priors(self, conv_h, conv_w, device): | |||
| """ Note that priors are [x,y,width,height] where (x,y) is the center of the box. """ | |||
| global prior_cache | |||
| size = (conv_h, conv_w) | |||
| assert(cfg.max_size > 350),"Segmentation does not work with too low-res images. Try providing input images with size atleast 350pix." | |||
There was a problem hiding this comment.
is 350 a resonable minimum? Guess it should be compared to backbone's sizes (550x550), how do I access that?
There was a problem hiding this comment.
350 is reasonable, but should this be a warning not an assert? I don't want to limit anyone from testing a low resolution.
Also this should be in YOLACT's init function, not in the make_priors function.
There was a problem hiding this comment.
Thanks for the feedback, modified accordingly
This reverts commit 4a8fe0e.
make it a warning, checked in Yolact init() review feedback, thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as segmentation does not work well if images are too low resolution.
Fixes #319